To compare the contents of two arrays, you must compare the elements of the two arrays.

Question

Problem :

My function accepts the two arrays of integers and returns true if below conditions are met

1.      Arrays have the same length and

2.      Each m.element should be less than each n.element of the same index

All my test cases are passing except when int[] m = {1, 2, 3} and int[] n = {4, 5, 1}.

It is returning true even if m[2] > n[2]. Here digitDifference check is not working correctly but I am not getting any error.

Please find below my code:

public static boolean ArrayLess(int[] m, int[] n) {

    int j = 0;

    boolean sameLength = (m.length == n.length);

    boolean digitDifference = (m[j] < n[j]);

    for (j = 0; j <= m.length - 1; j++) {}

    return (sameLength && digitDifference);

}

Answer 1

I guess your for loop does nothing, so I think you are only comparing the elements in the first index of your arrays.

Your code must look something like below :

public static boolean ArrayLess (int[] m, int[] n) {

boolean sameLength = (m.length == n.length);

if (!sameLength)

   return false;

    boolean digitDifference = true;

    for (int j = 0; j <= m.length - 1 && digitDifference;j++) {

        digitDifference = (m[j] < n[j]);

    }

    return digitDifference;

}

Now the newly updated for loop in above code compares each pair of elements having the same index, and terminates if it finds a pair that against your requirement that (m[j] < n[j]).