Rock Paper Scissors c++ using functions

Question

Problem:

Hello good people,

I just completed the basic C++ programming course by taking help from a YouTube channel. It was a 15-days long course. After completing the course they give an exercise/assignment. They asked me to write a program of Rock-Paper-Scissors game of two players. So, I gave it a try and write some codes to make a game like that. Find my sample code snippet below and dig into it, please

#include <iostream> 
#include <cstdlib> 
#include <stdio.h>
using namespace std; 

int main() 
{ 
    string fp; 
    string sp; 
    string r; 
    string p; 
    string s; 

    cout << "Rock, Paper, Scissors Game\n"; 
    cout << "\nPlayer One, please enter your move: ('p' for Paper, 'r' for Rock, 's' for Scissor)";  

    cin >> fp; 

    cout << "\nPlayer Two, please enter your move: ('p' for Paper, 'r' for Rock, 's' for Scissor)"; 

    cin >> sp; 

    if (fp == sp) 
    { 
        cout <<"\nThere is a tie"<<endl; 
    } 

    if ( fp == r && sp == p) 
    { 
        cout << "\nPaper wraps rock, Player 1 win"; 
    } 
    else if (fp == r && sp == s) 
    { 
        cout << "\nRock smashes scissors, player 1 win"; 
    } 

    if (fp == p && sp == r) 
    { 
        cout <<"\nPaper wraps rock, player 1 win"; 
    } 
    else if ( fp == p && sp == s) 
    { 
        cout <<"\nScissors cut paper, player 2 win"; 
    } 

    if ( fp == r && sp == p) 
    { 
        cout << "\nPaper wraps rock, Player 1 win"; 
    } 
    else if (fp == r && sp == s) 
    { 
        cout << "\nRock smashes scissors, player 1 win"; 
    } 

    if (fp == p && sp == r) 
    { 
        cout <<"\nPaper wraps rock, player 1 win"; 
    } 
    else if ( fp == p && sp == s) 
    { 
        cout <<"\nScissors cut paper, player 2 win"; 
    } 

    if ( sp == s && fp == r) 
    { 
        cout <<"\nScissors cut paper, player 1 win"; 
    } 
    else if (sp == s && fp == p) 
    { 
        cout <<"\nRock smashes scissors, player 2 win "; 
    } 

    return 0; 
}

The above program is not printing any results. I tried so hard but still couldn’t figure the problem in my codes. Could anybody please save me this time?

Thanks for your kind help.

Answer 1

First of all, you missed the double quotes around your strings “r”, “p”, “s” inside the if-elf statement. Remember, you can’t write strings without the double-quotes. The strings must stay inside the ( “ ” ) So, change the action inside your if-elf statements first. One more thing you did wrong. You repeated the second and third if-elf block in your code. Omit them from your code. Then it should run fine. Let me write the code in this way:

#include <iostream> 
#include <cstdlib>
#include <stdio.h>
using namespace std;
int main(){ 
    string fp; 
    string sp; 
    string r; 
    string p; 
    string s; 
    cout << "Rock, Paper, Scissors Game\n"; 
    cout << "\nPlayer One, please enter your move: ('p' for Paper, 'r' for Rock, 's' for Scissor)";  
    cin >> fp; 
    cout << "\n\nplayer Two, please enter your move: ('p' for Paper, 'r' for Rock, 's' for Scissor)"; 
    cin >> sp;
    if (fp == sp){ 
        cout <<"\n\n\nThis is a tie"<<endl; 
    }

    if ( fp == "r" && sp == "p"){ 
        cout << "\nPaper wraps rock, Player 1 win"; 
    }
    
    else if (fp == "r" && sp == "s"){ 
        cout << "\nRock smashes scissors, player 1 win"; 
    } 

    if (fp == "p" && sp == "r"){ 
        cout <<"\nPaper wraps rock, player 1 win"; 
    }
    
    else if ( fp == "p" && sp == "s"){ 
        cout <<"\nScissors cut paper, player 2 win"; 
    }

    if ( sp == "s" && fp == "r"){ 
        cout <<"\nScissors cut paper, player 1 win"; 
    }
    
    else if (sp == "s" && fp == "p"){ 
        cout <<"\nRock smashes scissors, player 2 win "; 
    } 

    return 0; 
}

Leave your reply below if you got further queries. Thanks.

Answer 2

#include <iostream>
#include <cstdlib>  // For rand() and srand()
#include <ctime>    // For the time() function

// Constant variables
const int ROCK = 1,
          PAPER = 2,
          SCISSORS = 3;

// Function Prototypes
int inputValidate(int);
int computerChoice(int);
int getUserChoice(int);
void displayRandomNumber(int);
void winnerSelection(int, int, bool &);

using namespace std;

int main()
{
    int computer_choice,
        user_number;

    bool play_again;

    do
    {
        computer_choice = computerChoice(computer_choice);

        user_number = getUserChoice(user_number);

        displayRandomNumber(computer_choice);

        winnerSelection(computer_choice, user_number, play_again);

    } while (play_again == 1);

    return 0;
} // END int main()

int computerChoice(int computer_choice)
{
    // Get the system time.
    unsigned seed = time(0);

    // Seed the random number generator.
    srand(seed);

    // Random number
    return (rand() % (SCISSORS - ROCK + 1)) + ROCK;
}

int getUserChoice(int user_number)
{
    cout << "\nChoose 'rock', 'paper', or 'scissors'.\n"
         << "(1) for rock, (2) for paper, or (3) for scissors: ";
         
    user_number = inputValidate(user_number);

    return user_number;
}

int inputValidate(int num1)
{

    while (!(cin >> num1) || (num1 < 1 || num1 > 3))
    {
        cout << "Error. Number must not be "
             << " 0 or greater: ";
        cin.clear();
        cin.ignore(numeric_limits<streamsize>::max(), '\n');
    }

    return num1;
}

void displayRandomNumber(int computer_choice)
{
    cout << "\nComputer Choice = ";

    if (computer_choice == 1)
        cout << "Rock";
    else if (computer_choice == 2)
        cout << "Paper";
    else if (computer_choice == 3)
        cout << "Scissors";

    cout << endl;
}

void winnerSelection(int computer_choice,
                     int user_number,
                     bool &play_again)
{
    cout << endl;

    if (computer_choice == ROCK)
    {
        if (user_number == PAPER)
        {
            cout << "You win: (Paper covers rock).\n";
            play_again = 0;
        }
        else if (user_number == SCISSORS)
        {
            cout << "Computer wins: (Rock smashes scissors).\n";
            play_again = 0;
        }
        else if (user_number == ROCK)
        {
            cout << "Tie. Play again to determine the winner." << endl;
            play_again = 1;
        }
    }
    else if (computer_choice == PAPER)
    {
        if (user_number == ROCK)
        {
            cout << "Computer wins: (Paper covers rock).\n";
            play_again = 0;
        }
        else if (user_number == SCISSORS)
        {
            cout << "You win: (Scissors cuts paper).\n";
            play_again = 0;
        }
        else if (user_number == PAPER)
        {
            cout << "Tie. Play again to determine the winner." << endl;
            play_again = 1;
        }
    }
    else if (computer_choice == SCISSORS)
    {
        if (user_number == ROCK)
        {
            cout << "You win: (Rock smashes scissors).\n";
            play_again = 0;
        }
        else if (user_number == PAPER)
        {
            cout << "Computer wins: (Scissors cuts paper).\n";
            play_again = 0;
        }
        else if (user_number == SCISSORS)
        {
            cout << "Tie. Play again to determine the winner." << endl;
            play_again = 1;
        }
    }

    cout << endl;
}

Here's your issue:

if (pone == r && ptwo == p) 
{ 
    cout << "\nPaper wraps rock, Player 1 win"; 
} 
else if (pone == r && ptwo == s) 
{ 
    cout << "\nRock smashes scissors, player 1 win"; 
} 
//etc etc

Place those "r", "p", and "s" in quotes like such:

if (pone == "r" && ptwo == "p")
//etc etc